From 389aab8d4a4b51119b50c8cb13bafff85515a814 Mon Sep 17 00:00:00 2001 From: Pascal Vizeli Date: Thu, 7 Jul 2022 19:20:00 +0200 Subject: [PATCH] Output backup log on error (#3722) * Output backup log on error * Apply suggestions from code review Co-authored-by: Mike Degatano Co-authored-by: Mike Degatano --- supervisor/addons/addon.py | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/supervisor/addons/addon.py b/supervisor/addons/addon.py index b6be85b53..a94050f01 100644 --- a/supervisor/addons/addon.py +++ b/supervisor/addons/addon.py @@ -681,16 +681,18 @@ class Addon(AddonModel): try: command_return = await self.instance.run_inside(command) if command_return.exit_code != 0: - _LOGGER.error( - "Pre-/Post backup command returned error code: %s", - command_return.exit_code, + _LOGGER.debug( + "Pre-/Post backup command failed with: %s", command_return.output + ) + raise AddonsError( + f"Pre-/Post backup command returned error code: {command_return.exit_code}", + _LOGGER.error, ) - raise AddonsError() except DockerError as err: - _LOGGER.error( - "Failed running pre-/post backup command %s: %s", command, err - ) - raise AddonsError() from err + raise AddonsError( + f"Failed running pre-/post backup command {command}: {str(err)}", + _LOGGER.error, + ) from err async def backup(self, tar_file: tarfile.TarFile) -> None: """Backup state of an add-on."""