Use await for all FileConfiguration calls (#5683)

Some calls got missed in PR #5652. Update all calls to await the
save_data() coroutine.
This commit is contained in:
Stefan Agner 2025-02-27 15:38:57 +01:00 committed by GitHub
parent ddee79d209
commit 39f5b91f12
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
17 changed files with 34 additions and 34 deletions

View File

@ -852,7 +852,7 @@ class Addon(AddonModel):
for service in self.sys_services.list_services:
if self.slug not in service.active:
continue
service.del_service_data(self)
await service.del_service_data(self)
# Remove from addon manager
await self.sys_addons.data.uninstall(self)

View File

@ -212,7 +212,7 @@ class APIBackups(CoreSysAttributes):
if ATTR_DAYS_UNTIL_STALE in body:
self.sys_backups.days_until_stale = body[ATTR_DAYS_UNTIL_STALE]
self.sys_backups.save_data()
await self.sys_backups.save_data()
@api_process
async def reload(self, _):

View File

@ -78,7 +78,7 @@ class APICoreDNS(CoreSysAttributes):
if restart_required:
self.sys_create_task(self.sys_plugins.dns.restart())
self.sys_plugins.dns.save_data()
await self.sys_plugins.dns.save_data()
@api_process
async def stats(self, request: web.Request) -> dict[str, Any]:

View File

@ -53,7 +53,7 @@ class APIDocker(CoreSysAttributes):
for hostname, registry in body.items():
self.sys_docker.config.registries[hostname] = registry
self.sys_docker.config.save_data()
await self.sys_docker.config.save_data()
@api_process
async def remove_registry(self, request: web.Request):
@ -63,7 +63,7 @@ class APIDocker(CoreSysAttributes):
raise APINotFound(f"Hostname {hostname} does not exist in registries")
del self.sys_docker.config.registries[hostname]
self.sys_docker.config.save_data()
await self.sys_docker.config.save_data()
@api_process
async def info(self, request: web.Request):

View File

@ -149,7 +149,7 @@ class APIHomeAssistant(CoreSysAttributes):
ATTR_BACKUPS_EXCLUDE_DATABASE
]
self.sys_homeassistant.save_data()
await self.sys_homeassistant.save_data()
@api_process
async def stats(self, request: web.Request) -> dict[Any, str]:

View File

@ -92,7 +92,7 @@ class APIJobs(CoreSysAttributes):
if ATTR_IGNORE_CONDITIONS in body:
self.sys_jobs.ignore_conditions = body[ATTR_IGNORE_CONDITIONS]
self.sys_jobs.save_data()
await self.sys_jobs.save_data()
await self.sys_resolution.evaluate.evaluate_system()

View File

@ -66,7 +66,7 @@ class APIMounts(CoreSysAttributes):
else:
self.sys_mounts.default_backup_mount = mount
self.sys_mounts.save_data()
await self.sys_mounts.save_data()
@api_process
async def create_mount(self, request: web.Request) -> None:
@ -87,7 +87,7 @@ class APIMounts(CoreSysAttributes):
if not self.sys_mounts.default_backup_mount:
self.sys_mounts.default_backup_mount = mount
self.sys_mounts.save_data()
await self.sys_mounts.save_data()
@api_process
async def update_mount(self, request: web.Request) -> None:
@ -110,7 +110,7 @@ class APIMounts(CoreSysAttributes):
elif self.sys_mounts.default_backup_mount == mount:
self.sys_mounts.default_backup_mount = None
self.sys_mounts.save_data()
await self.sys_mounts.save_data()
@api_process
async def delete_mount(self, request: web.Request) -> None:
@ -122,7 +122,7 @@ class APIMounts(CoreSysAttributes):
if mount.usage == MountUsage.BACKUP:
self.sys_create_task(self.sys_backups.reload())
self.sys_mounts.save_data()
await self.sys_mounts.save_data()
@api_process
async def reload_mount(self, request: web.Request) -> None:

View File

@ -169,7 +169,7 @@ class APIOS(CoreSysAttributes):
body[ATTR_SYSTEM_HEALTH_LED]
)
self.sys_dbus.agent.board.green.save_data()
await self.sys_dbus.agent.board.green.save_data()
@api_process
async def boards_yellow_info(self, request: web.Request) -> dict[str, Any]:
@ -196,7 +196,7 @@ class APIOS(CoreSysAttributes):
if ATTR_POWER_LED in body:
await self.sys_dbus.agent.board.yellow.set_power_led(body[ATTR_POWER_LED])
self.sys_dbus.agent.board.yellow.save_data()
await self.sys_dbus.agent.board.yellow.save_data()
self.sys_resolution.create_issue(
IssueType.REBOOT_REQUIRED,
ContextType.SYSTEM,

View File

@ -126,7 +126,7 @@ class APIResoulution(CoreSysAttributes):
if ATTR_ENABLED in body:
check.enabled = body[ATTR_ENABLED]
self.sys_resolution.save_data()
await self.sys_resolution.save_data()
@api_process
async def run_check(self, request: web.Request) -> None:

View File

@ -48,7 +48,7 @@ class APISecurity(CoreSysAttributes):
if ATTR_FORCE_SECURITY in body:
self.sys_security.force = body[ATTR_FORCE_SECURITY]
self.sys_security.save_data()
await self.sys_security.save_data()
await self.sys_resolution.evaluate.evaluate_system()

View File

@ -47,7 +47,7 @@ class APIServices(CoreSysAttributes):
addon = request[REQUEST_FROM]
_check_access(request, service.slug)
service.set_service_data(addon, body)
await service.set_service_data(addon, body)
@api_process
async def get_service(self, request):
@ -69,7 +69,7 @@ class APIServices(CoreSysAttributes):
# Access
_check_access(request, service.slug, True)
service.del_service_data(addon)
await service.del_service_data(addon)
def _check_access(request, service, provide=False):

View File

@ -159,8 +159,8 @@ class APISupervisor(CoreSysAttributes):
self.sys_config.wait_boot = body[ATTR_WAIT_BOOT]
# Save changes before processing addons in case of errors
self.sys_updater.save_data()
self.sys_config.save_data()
await self.sys_updater.save_data()
await self.sys_config.save_data()
# Remove: 2022.9
if ATTR_ADDONS_REPOSITORIES in body:

View File

@ -25,7 +25,7 @@ class FixupMountExecuteRemove(FixupBase):
except MountNotFound:
_LOGGER.warning("Can't find mount %s for fixup", reference)
else:
self.sys_mounts.save_data()
await self.sys_mounts.save_data()
@property
def suggestion(self) -> SuggestionType:

View File

@ -51,9 +51,9 @@ class ServiceInterface(CoreSysAttributes, ABC):
"""Return True if the service is in use."""
return bool(self._data)
def save(self) -> None:
async def save(self) -> None:
"""Save changes."""
self.sys_services.data.save_data()
await self.sys_services.data.save_data()
def get_service_data(self) -> dict[str, Any] | None:
"""Return the requested service data."""
@ -62,9 +62,9 @@ class ServiceInterface(CoreSysAttributes, ABC):
return None
@abstractmethod
def set_service_data(self, addon: Addon, data: dict[str, Any]) -> None:
async def set_service_data(self, addon: Addon, data: dict[str, Any]) -> None:
"""Write the data into service object."""
@abstractmethod
def del_service_data(self, addon: Addon) -> None:
async def del_service_data(self, addon: Addon) -> None:
"""Remove the data from service object."""

View File

@ -65,7 +65,7 @@ class MQTTService(ServiceInterface):
return []
return [self._data[ATTR_ADDON]]
def set_service_data(self, addon: Addon, data: dict[str, Any]) -> None:
async def set_service_data(self, addon: Addon, data: dict[str, Any]) -> None:
"""Write the data into service object."""
if self.enabled:
raise ServicesError(
@ -77,9 +77,9 @@ class MQTTService(ServiceInterface):
self._data[ATTR_ADDON] = addon.slug
_LOGGER.info("Set %s as service provider for mqtt", addon.slug)
self.save()
await self.save()
def del_service_data(self, addon: Addon) -> None:
async def del_service_data(self, addon: Addon) -> None:
"""Remove the data from service object."""
if not self.enabled:
raise ServicesError(
@ -87,4 +87,4 @@ class MQTTService(ServiceInterface):
)
self._data.clear()
self.save()
await self.save()

View File

@ -59,7 +59,7 @@ class MySQLService(ServiceInterface):
return []
return [self._data[ATTR_ADDON]]
def set_service_data(self, addon: Addon, data: dict[str, Any]) -> None:
async def set_service_data(self, addon: Addon, data: dict[str, Any]) -> None:
"""Write the data into service object."""
if self.enabled:
raise ServicesError(
@ -71,12 +71,12 @@ class MySQLService(ServiceInterface):
self._data[ATTR_ADDON] = addon.slug
_LOGGER.info("Set %s as service provider for MySQL", addon.slug)
self.save()
await self.save()
def del_service_data(self, addon: Addon) -> None:
async def del_service_data(self, addon: Addon) -> None:
"""Remove the data from service object."""
if not self.enabled:
raise ServicesError("Can't remove not exists services", _LOGGER.warning)
self._data.clear()
self.save()
await self.save()

View File

@ -206,7 +206,7 @@ class StoreManager(CoreSysAttributes, FileConfiguration):
# On start-up we add the saved repos to force a load. But they're already in data
if url not in self._data[ATTR_REPOSITORIES]:
self._data[ATTR_REPOSITORIES].append(url)
self.save_data()
await self.save_data()
# Persist changes
if persist:
@ -227,7 +227,7 @@ class StoreManager(CoreSysAttributes, FileConfiguration):
)
await self.repositories.pop(repository.slug).remove()
self._data[ATTR_REPOSITORIES].remove(repository.source)
self.save_data()
await self.save_data()
if persist:
await self.data.update()