Allow mounting CIFS as guest (#4384)

supervisor/mounts/mount.py

@@ -359,8 +359,8 @@ class CIFSMount(NetworkMount):
         """Options to use to mount."""
         return (
             super().options + [f"username={self.username}", f"password={self.password}"]
-            if self.username
-            else []
+            if self.username and self.password
+            else ["guest"]
         )
 
 

tests/mounts/test_manager.py

@@ -116,6 +116,7 @@ async def test_load(
             "mnt-data-supervisor-mounts-backup_test.mount",
             "fail",
             [
+                ["Options", Variant("s", "guest")],
                 ["Type", Variant("s", "cifs")],
                 ["Description", Variant("s", "Supervisor cifs mount: backup_test")],
                 ["What", Variant("s", "//backup.local/backups")],

tests/mounts/test_mount.py

@@ -177,6 +177,7 @@ async def test_load(
             "mnt-data-supervisor-mounts-test.mount",
             "fail",
             [
+                ["Options", Variant("s", "guest")],
                 ["Type", Variant("s", "cifs")],
                 ["Description", Variant("s", "Supervisor cifs mount: test")],
                 ["What", Variant("s", "//test.local/share")],