From 9024085712871b29b598f5dadd3c412c11498601 Mon Sep 17 00:00:00 2001
From: Mike Degatano <michael.degatano@gmail.com>
Date: Tue, 24 Jan 2023 12:41:00 -0500
Subject: [PATCH] Don't log error for addon unavailable (#4115)

---
 supervisor/addons/model.py | 14 ++++++++------
 tests/api/test_store.py    |  9 ++++++++-
 2 files changed, 16 insertions(+), 7 deletions(-)

diff --git a/supervisor/addons/model.py b/supervisor/addons/model.py
index 1be4c415e..cd5422c26 100644
--- a/supervisor/addons/model.py
+++ b/supervisor/addons/model.py
@@ -1,6 +1,6 @@
 """Init file for Supervisor add-ons."""
 from abc import ABC, abstractmethod
-from collections.abc import Awaitable
+from collections.abc import Awaitable, Callable
 from contextlib import suppress
 import logging
 from pathlib import Path
@@ -602,7 +602,7 @@ class AddonModel(CoreSysAttributes, ABC):
 
     def validate_availability(self) -> None:
         """Validate if addon is available for current system."""
-        return self._validate_availability(self.data)
+        return self._validate_availability(self.data, logger=_LOGGER.error)
 
     def __eq__(self, other):
         """Compaired add-on objects."""
@@ -610,13 +610,15 @@ class AddonModel(CoreSysAttributes, ABC):
             return False
         return self.slug == other.slug
 
-    def _validate_availability(self, config) -> None:
+    def _validate_availability(
+        self, config, *, logger: Callable[..., None] | None = None
+    ) -> None:
         """Validate if addon is available for current system."""
         # Architecture
         if not self.sys_arch.is_supported(config[ATTR_ARCH]):
             raise AddonsNotSupportedError(
                 f"Add-on {self.slug} not supported on this platform, supported architectures: {', '.join(config[ATTR_ARCH])}",
-                _LOGGER.error,
+                logger,
             )
 
         # Machine / Hardware
@@ -626,7 +628,7 @@ class AddonModel(CoreSysAttributes, ABC):
         ):
             raise AddonsNotSupportedError(
                 f"Add-on {self.slug} not supported on this machine, supported machine types: {', '.join(machine)}",
-                _LOGGER.error,
+                logger,
             )
 
         # Home Assistant
@@ -635,7 +637,7 @@ class AddonModel(CoreSysAttributes, ABC):
             if self.sys_homeassistant.version < version:
                 raise AddonsNotSupportedError(
                     f"Add-on {self.slug} not supported on this system, requires Home Assistant version {version} or greater",
-                    _LOGGER.error,
+                    logger,
                 )
 
     def _available(self, config) -> bool:
diff --git a/tests/api/test_store.py b/tests/api/test_store.py
index 68bdc3bde..cf7c71de3 100644
--- a/tests/api/test_store.py
+++ b/tests/api/test_store.py
@@ -13,7 +13,10 @@ REPO_URL = "https://github.com/awesome-developer/awesome-repo"
 
 @pytest.mark.asyncio
 async def test_api_store(
-    api_client: TestClient, store_addon: AddonStore, repository: Repository
+    api_client: TestClient,
+    store_addon: AddonStore,
+    repository: Repository,
+    caplog: pytest.LogCaptureFixture,
 ):
     """Test /store REST API."""
     resp = await api_client.get("/store")
@@ -22,6 +25,10 @@ async def test_api_store(
     assert result["data"]["addons"][-1]["slug"] == store_addon.slug
     assert result["data"]["repositories"][-1]["slug"] == repository.slug
 
+    assert (
+        f"Add-on {store_addon.slug} not supported on this platform" not in caplog.text
+    )
+
 
 @pytest.mark.asyncio
 async def test_api_store_addons(api_client: TestClient, store_addon: AddonStore):