From ced72e127342185436c676096ed33e742360240c Mon Sep 17 00:00:00 2001
From: Pascal Vizeli <pvizeli@syshack.ch>
Date: Thu, 12 Nov 2020 10:11:38 +0100
Subject: [PATCH] Fix show update if version is None (#2244)

---
 supervisor/hassos.py                 | 2 +-
 supervisor/homeassistant/__init__.py | 2 ++
 supervisor/plugins/audio.py          | 2 +-
 supervisor/plugins/cli.py            | 2 +-
 supervisor/plugins/dns.py            | 2 +-
 supervisor/plugins/multicast.py      | 2 +-
 supervisor/plugins/observer.py       | 2 +-
 supervisor/supervisor.py             | 2 +-
 8 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/supervisor/hassos.py b/supervisor/hassos.py
index cd2fe9276..8cafeafe3 100644
--- a/supervisor/hassos.py
+++ b/supervisor/hassos.py
@@ -49,7 +49,7 @@ class HassOS(CoreSysAttributes):
         try:
             return pkg_parse(self.version) < pkg_parse(self.latest_version)
         except (TypeError, ValueError):
-            return True
+            return False
 
     @property
     def board(self) -> Optional[str]:
diff --git a/supervisor/homeassistant/__init__.py b/supervisor/homeassistant/__init__.py
index 796bbcc79..b11a12a2c 100644
--- a/supervisor/homeassistant/__init__.py
+++ b/supervisor/homeassistant/__init__.py
@@ -220,6 +220,8 @@ class HomeAssistant(JsonConfig, CoreSysAttributes):
     @property
     def need_update(self) -> bool:
         """Return true if a Home Assistant update is available."""
+        if not self.latest_version:
+            return False
         return self.version != self.latest_version
 
     async def load(self) -> None:
diff --git a/supervisor/plugins/audio.py b/supervisor/plugins/audio.py
index 1aaa7365b..5fcede2ba 100644
--- a/supervisor/plugins/audio.py
+++ b/supervisor/plugins/audio.py
@@ -87,7 +87,7 @@ class Audio(JsonConfig, CoreSysAttributes):
         try:
             return pkg_parse(self.version) < pkg_parse(self.latest_version)
         except (TypeError, ValueError):
-            return True
+            return False
 
     async def load(self) -> None:
         """Load Audio setup."""
diff --git a/supervisor/plugins/cli.py b/supervisor/plugins/cli.py
index 499fb293c..8785effe2 100644
--- a/supervisor/plugins/cli.py
+++ b/supervisor/plugins/cli.py
@@ -66,7 +66,7 @@ class HaCli(CoreSysAttributes, JsonConfig):
         try:
             return pkg_parse(self.version) < pkg_parse(self.latest_version)
         except (TypeError, ValueError):
-            return True
+            return False
 
     @property
     def supervisor_token(self) -> str:
diff --git a/supervisor/plugins/dns.py b/supervisor/plugins/dns.py
index 14ce2f2de..1f9b3ec8c 100644
--- a/supervisor/plugins/dns.py
+++ b/supervisor/plugins/dns.py
@@ -126,7 +126,7 @@ class CoreDNS(JsonConfig, CoreSysAttributes):
         try:
             return pkg_parse(self.version) < pkg_parse(self.latest_version)
         except (TypeError, ValueError):
-            return True
+            return False
 
     async def load(self) -> None:
         """Load DNS setup."""
diff --git a/supervisor/plugins/multicast.py b/supervisor/plugins/multicast.py
index 66ed5a487..7d3c6bded 100644
--- a/supervisor/plugins/multicast.py
+++ b/supervisor/plugins/multicast.py
@@ -70,7 +70,7 @@ class Multicast(JsonConfig, CoreSysAttributes):
         try:
             return pkg_parse(self.version) < pkg_parse(self.latest_version)
         except (TypeError, ValueError):
-            return True
+            return False
 
     async def load(self) -> None:
         """Load multicast setup."""
diff --git a/supervisor/plugins/observer.py b/supervisor/plugins/observer.py
index a78ae78d8..7d4725ae6 100644
--- a/supervisor/plugins/observer.py
+++ b/supervisor/plugins/observer.py
@@ -67,7 +67,7 @@ class Observer(CoreSysAttributes, JsonConfig):
         try:
             return pkg_parse(self.version) < pkg_parse(self.latest_version)
         except (TypeError, ValueError):
-            return True
+            return False
 
     @property
     def supervisor_token(self) -> str:
diff --git a/supervisor/supervisor.py b/supervisor/supervisor.py
index 17072b403..be4bb1184 100644
--- a/supervisor/supervisor.py
+++ b/supervisor/supervisor.py
@@ -57,7 +57,7 @@ class Supervisor(CoreSysAttributes):
         try:
             return pkg_parse(self.version) < pkg_parse(self.latest_version)
         except (TypeError, ValueError):
-            return True
+            return False
 
     @property
     def version(self) -> str: