jeans/supervisor
jeans/supervisor
1
0
Fork 0
mirror of https://github.com/home-assistant/supervisor.git synced 2025-07-21 08:06:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use new format for logging exceptions - host/network.py (#3196)

Browse Source
This commit is contained in:
Prathamesh Gawas 2021-10-05 01:53:55 +05:30 committed by GitHub
parent 5af62a8834
commit f344df9e5c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
supervisor/host/network.py
View File

@ -111,8 +111,9 @@ class NetworkManager(CoreSysAttributes):
except DBusError: except DBusError:
_LOGGER.warning("Can't update network information!") _LOGGER.warning("Can't update network information!")
except DBusNotConnectedError as err: except DBusNotConnectedError as err:
_LOGGER.error("No network D-Bus connection available") raise HostNotSupportedError(
raise HostNotSupportedError() from err "No network D-Bus connection available", _LOGGER.error
) from err
await self.check_connectivity() await self.check_connectivity()
@ -139,8 +140,9 @@ class NetworkManager(CoreSysAttributes):
inet.settings.object_path, inet.object_path inet.settings.object_path, inet.object_path
) )
except DBusError as err: except DBusError as err:
_LOGGER.error("Can't update config on %s: %s", interface.name, err) raise HostNetworkError(
raise HostNetworkError() from err f"Can't update config on {interface.name}: {err}", _LOGGER.error
) from err
# Create new configuration and activate interface # Create new configuration and activate interface
elif inet and interface.enabled: elif inet and interface.enabled:
@ -151,18 +153,19 @@ class NetworkManager(CoreSysAttributes):
settings, inet.object_path settings, inet.object_path
) )
except DBusError as err: except DBusError as err:
_LOGGER.error( raise HostNetworkError(
"Can't create config and activate %s: %s", interface.name, err f"Can't create config and activate {interface.name}: {err}",
) _LOGGER.error,
raise HostNetworkError() from err ) from err
# Remove config from interface # Remove config from interface
elif inet and inet.settings and not interface.enabled: elif inet and inet.settings and not interface.enabled:
try: try:
await inet.settings.delete() await inet.settings.delete()
except DBusError as err: except DBusError as err:
_LOGGER.error("Can't disable interface %s: %s", interface.name, err) raise HostNetworkError(
raise HostNetworkError() from err f"Can't disable interface {interface.name}: {err}", _LOGGER.error
) from err
# Create new interface (like vlan) # Create new interface (like vlan)
elif not inet: elif not inet:
@ -171,11 +174,13 @@ class NetworkManager(CoreSysAttributes):
try: try:
await self.sys_dbus.network.settings.add_connection(settings) await self.sys_dbus.network.settings.add_connection(settings)
except DBusError as err: except DBusError as err:
_LOGGER.error("Can't create new interface: %s", err) raise HostNetworkError(
raise HostNetworkError() from err f"Can't create new interface: {err}", _LOGGER.error
) from err
else: else:
_LOGGER.warning("Requested Network interface update is not possible") raise HostNetworkError(
raise HostNetworkError() "Requested Network interface update is not possible", _LOGGER.warning
)
await self.sys_dbus.network.dbus.wait_signal( await self.sys_dbus.network.dbus.wait_signal(
DBUS_NAME_NM_CONNECTION_ACTIVE_CHANGED DBUS_NAME_NM_CONNECTION_ACTIVE_CHANGED
@ -187,8 +192,9 @@ class NetworkManager(CoreSysAttributes):
inet = self.sys_dbus.network.interfaces.get(interface.name) inet = self.sys_dbus.network.interfaces.get(interface.name)
if inet.type != DeviceType.WIRELESS: if inet.type != DeviceType.WIRELESS:
_LOGGER.error("Can only scan with wireless card - %s", interface.name) raise HostNotSupportedError(
raise HostNotSupportedError() f"Can only scan with wireless card - {interface.name}", _LOGGER.error
)
# Request Scan # Request Scan
try: try: