* Set 600 premissions on json files
* Add test
* Fix local tar tests
* Fix tar test in action
* Use pytest fixture for tmp_path in tests
* remove not needed things
* Do not use `tar_file.add` to recursively add backup folder
As the folders might contain files which are being removed temporarily (e.g. shared memory file of sqlite database), relying on `tar_file.add` becomes problematic as it crashes the whole backup process if a file does not exist anymore.
This becomes annoying, if the file which causes the error should be excluded by the filter.
To workaround this issue, we manually iterating over the files/directories and apply filters before passing the file or directory to the `tar_file.add` method. As per [documentation](https://docs.python.org/3/library/pathlib.html#pure-paths), pure path does not access the file system.
Fixes#779
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Remove unused import
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Applied code review suggestions
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Applied codestyle
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Remove `pathlib` util and move `is_excluded_by_filter` into `tar` utils
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Rename method
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Rename `origin_dir` to `origin_path` and apply `Path` typehint
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Codestyle
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Add comment why we add the directory even if we are iterating over all its items
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Use `atomic_contents_add` from tar utils to archive addon data
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Remove unused function `exclude_filter`
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Remove unsecure default list value
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Some more codestyle
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Lowercase method name `Path.joinpath`
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Fix codestyle and use proper variable
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Add test for `_is_excluded_by_filter`
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
* Update addon.py
Co-authored-by: Pascal Vizeli <pascal.vizeli@syshack.ch>