mirror of
https://github.com/home-assistant/supervisor.git
synced 2025-11-16 22:40:47 +00:00
9088810b49
* Improve D-Bus error handling for NetworkManager There are quite some errors captured which are related by seemingly a suddenly missing NetworkManager. Errors appear as: 23-11-21 17:42:50 ERROR (MainThread) [supervisor.dbus.network] Error while processing /org/freedesktop/NetworkManager/Devices/10: Remote peer disconnected ... 23-11-21 17:42:50 ERROR (MainThread) [supervisor.dbus.network] Error while processing /org/freedesktop/NetworkManager/Devices/35: The name is not activatable Both errors seem to already happen at introspection time, however the current code doesn't converts these errors to Supervisor issues. This PR uses the already existing `DBus.from_dbus_error()`. Furthermore this adds a new Exception `DBusNoReplyError` for the `ErrorType.NO_REPLY` (or `org.freedesktop.DBus.Error.NoReply` in D-Bus terms, which is the type of the first of the two issues above). And finally it separates the `ErrorType.SERVICE_UNKNOWN` (or `org.freedesktop.DBus.Error.ServiceUnknown` in D-Bus terms, which is the second of the above issue) from `DBusInterfaceError` into a new `DBusServiceUnkownError`. This allows to handle errors more specifically. To avoid too much churn, all instances where `DBusInterfaceError` got handled, we are now also handling `DBusServiceUnkownError`. The `DBusNoReplyError` and `DBusServiceUnkownError` appear when the NetworkManager service stops or crashes. Instead of retrying every interface we know, just give up if one of these issues appear. This should significantly lower error messages users are seeing and Sentry events. * Remove unnecessary statement * Fix pytests * Make sure error strings are compared correctly * Fix typo/remove unnecessary pylint exception * Fix DBusError typing * Add pytest for from_dbus_error * Revert "Make sure error strings are compared correctly" This reverts commit 10dc2e4c3887532921414b4291fe3987186db408. * Add test cases --------- Co-authored-by: Mike Degatano <michael.degatano@gmail.com>
61 lines
1.8 KiB
Python
61 lines
1.8 KiB
Python
"""Test DNS Manager object."""
|
|
|
|
from ipaddress import IPv4Address
|
|
|
|
from dbus_fast.aio.message_bus import MessageBus
|
|
import pytest
|
|
|
|
from supervisor.dbus.network.configuration import DNSConfiguration
|
|
from supervisor.dbus.network.dns import NetworkManagerDNS
|
|
|
|
from tests.common import mock_dbus_services
|
|
from tests.dbus_service_mocks.network_dns_manager import DnsManager as DnsManagerService
|
|
|
|
|
|
@pytest.fixture(name="dns_manager_service")
|
|
async def fixture_dns_manager_service(
|
|
dbus_session_bus: MessageBus,
|
|
) -> DnsManagerService:
|
|
"""Mock DnsManager dbus service."""
|
|
yield (await mock_dbus_services({"network_dns_manager": None}, dbus_session_bus))[
|
|
"network_dns_manager"
|
|
]
|
|
|
|
|
|
async def test_dns(
|
|
dns_manager_service: DnsManagerService, dbus_session_bus: MessageBus
|
|
):
|
|
"""Test dns manager."""
|
|
dns_manager = NetworkManagerDNS()
|
|
|
|
assert dns_manager.mode is None
|
|
assert dns_manager.rc_manager is None
|
|
|
|
await dns_manager.connect(dbus_session_bus)
|
|
|
|
assert dns_manager.mode == "default"
|
|
assert dns_manager.rc_manager == "file"
|
|
assert dns_manager.configuration == [
|
|
DNSConfiguration(
|
|
[IPv4Address("192.168.30.1")], ["syshack.ch"], "eth0", 100, False
|
|
)
|
|
]
|
|
|
|
dns_manager_service.emit_properties_changed({"Mode": "test"})
|
|
await dns_manager_service.ping()
|
|
assert dns_manager.mode == "test"
|
|
|
|
dns_manager_service.emit_properties_changed({}, ["Mode"])
|
|
await dns_manager_service.ping()
|
|
await dns_manager_service.ping()
|
|
assert dns_manager.mode == "default"
|
|
|
|
|
|
async def test_dbus_dns_connect_error(
|
|
dbus_session_bus: MessageBus, caplog: pytest.LogCaptureFixture
|
|
):
|
|
"""Test connecting to dns error."""
|
|
dns_manager = NetworkManagerDNS()
|
|
await dns_manager.connect(dbus_session_bus)
|
|
assert "No DnsManager support on the host" in caplog.text
|