mirror of
https://github.com/wled/WLED.git
synced 2026-04-20 22:22:51 +00:00
Address code review feedback: use boolean coercion instead of logical OR
Co-authored-by: netmindz <442066+netmindz@users.noreply.github.com>
This commit is contained in:
@@ -3471,7 +3471,7 @@ function reportUpgradeEvent(info, oldVersion, alwaysReport) {
|
||||
.then(res => {
|
||||
if (res.ok) {
|
||||
showToast('Thank you for reporting!');
|
||||
updateVersionInfo(info.ver, false, alwaysReport || false);
|
||||
updateVersionInfo(info.ver, false, !!alwaysReport);
|
||||
} else {
|
||||
showToast('Report failed. Please try again later.', true);
|
||||
// Do NOT update version info on failure - user will be prompted again
|
||||
@@ -3488,7 +3488,7 @@ function updateVersionInfo(version, neverAsk, alwaysReport) {
|
||||
const versionInfo = {
|
||||
version: version,
|
||||
neverAsk: neverAsk,
|
||||
alwaysReport: alwaysReport || false
|
||||
alwaysReport: !!alwaysReport
|
||||
};
|
||||
|
||||
// Create a Blob with JSON content and use /upload endpoint
|
||||
|
||||
Reference in New Issue
Block a user