Add 100% coverage of Reolink camera platform (#124381)

* Add 100% camera test coverage

* review comments

* use DOMAIN instead of const.DOMAIN

* use entity_registry_enabled_by_default fixture

* fixes

tests/components/reolink/conftest.py

@@ -38,6 +38,7 @@ TEST_USE_HTTPS = True
 TEST_HOST_MODEL = "RLN8-410"
 TEST_ITEM_NUMBER = "P000"
 TEST_CAM_MODEL = "RLC-123"
+TEST_DUO_MODEL = "Reolink Duo PoE"
 
 
 @pytest.fixture

tests/components/reolink/test_binary_sensor.py

@@ -10,7 +10,7 @@ from homeassistant.const import STATE_OFF, STATE_ON, Platform
 from homeassistant.core import HomeAssistant
 from homeassistant.helpers import entity_registry as er
 
-from .conftest import TEST_NVR_NAME, TEST_UID
+from .conftest import TEST_DUO_MODEL, TEST_NVR_NAME, TEST_UID
 
 from tests.common import MockConfigEntry, async_fire_time_changed
 from tests.typing import ClientSessionGenerator
@@ -25,7 +25,7 @@ async def test_motion_sensor(
     entity_registry: er.EntityRegistry,
 ) -> None:
     """Test binary sensor entity with motion sensor."""
-    reolink_connect.model = "Reolink Duo PoE"
+    reolink_connect.model = TEST_DUO_MODEL
     reolink_connect.motion_detected.return_value = True
     with patch("homeassistant.components.reolink.PLATFORMS", [Platform.BINARY_SENSOR]):
         assert await hass.config_entries.async_setup(config_entry.entry_id)

tests/components/reolink/test_camera.py

@@ -0,0 +1,63 @@
+"""Test the Reolink camera platform."""
+
+from unittest.mock import MagicMock, patch
+
+import pytest
+from reolink_aio.exceptions import ReolinkError
+
+from homeassistant.components.camera import async_get_image, async_get_stream_source
+from homeassistant.config_entries import ConfigEntryState
+from homeassistant.const import STATE_IDLE, Platform
+from homeassistant.core import HomeAssistant
+from homeassistant.exceptions import HomeAssistantError
+
+from .conftest import TEST_DUO_MODEL, TEST_NVR_NAME
+
+from tests.common import MockConfigEntry
+from tests.typing import ClientSessionGenerator
+
+
+async def test_camera(
+    hass: HomeAssistant,
+    hass_client_no_auth: ClientSessionGenerator,
+    config_entry: MockConfigEntry,
+    reolink_connect: MagicMock,
+) -> None:
+    """Test camera entity with fluent."""
+    with patch("homeassistant.components.reolink.PLATFORMS", [Platform.CAMERA]):
+        assert await hass.config_entries.async_setup(config_entry.entry_id)
+    await hass.async_block_till_done()
+    assert config_entry.state is ConfigEntryState.LOADED
+
+    entity_id = f"{Platform.CAMERA}.{TEST_NVR_NAME}_fluent"
+    assert hass.states.get(entity_id).state == STATE_IDLE
+
+    # check getting a image from the camera
+    reolink_connect.get_snapshot.return_value = b"image"
+    assert (await async_get_image(hass, entity_id)).content == b"image"
+
+    reolink_connect.get_snapshot.side_effect = ReolinkError("Test error")
+    with pytest.raises(HomeAssistantError):
+        await async_get_image(hass, entity_id)
+
+    # check getting the stream source
+    assert await async_get_stream_source(hass, entity_id) is not None
+
+
+@pytest.mark.usefixtures("entity_registry_enabled_by_default")
+async def test_camera_no_stream_source(
+    hass: HomeAssistant,
+    config_entry: MockConfigEntry,
+    reolink_connect: MagicMock,
+) -> None:
+    """Test camera entity with no stream source."""
+    reolink_connect.model = TEST_DUO_MODEL
+    reolink_connect.get_stream_source.return_value = None
+
+    with patch("homeassistant.components.reolink.PLATFORMS", [Platform.CAMERA]):
+        assert await hass.config_entries.async_setup(config_entry.entry_id)
+    await hass.async_block_till_done()
+    assert config_entry.state is ConfigEntryState.LOADED
+
+    entity_id = f"{Platform.CAMERA}.{TEST_NVR_NAME}_snapshots_fluent_lens_0"
+    assert hass.states.get(entity_id).state == STATE_IDLE