jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-17 10:17:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix HTTP login attempts check triggering too late (#20431)

Browse Source
This commit is contained in:
Louis Matthijssen 2019-01-26 03:13:44 +01:00 committed by Anders Melchiorsen
parent 76c0295403
commit d39784906b
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
homeassistant/components/http/ban.py
View File

@ -104,7 +104,7 @@ async def process_wrong_login(request):
request.app[KEY_FAILED_LOGIN_ATTEMPTS][remote_addr] += 1 request.app[KEY_FAILED_LOGIN_ATTEMPTS][remote_addr] += 1
if (request.app[KEY_FAILED_LOGIN_ATTEMPTS][remote_addr] > if (request.app[KEY_FAILED_LOGIN_ATTEMPTS][remote_addr] >=
request.app[KEY_LOGIN_THRESHOLD]): request.app[KEY_LOGIN_THRESHOLD]):
new_ban = IpBan(remote_addr) new_ban = IpBan(remote_addr)
request.app[KEY_BANNED_IPS].append(new_ban) request.app[KEY_BANNED_IPS].append(new_ban)

2
tests/components/http/test_ban.py
View File

@ -71,7 +71,7 @@ async def test_ip_bans_file_creation(hass, aiohttp_client):
raise HTTPUnauthorized raise HTTPUnauthorized
app.router.add_get('/', unauth_handler) app.router.add_get('/', unauth_handler)
setup_bans(hass, app, 1) setup_bans(hass, app, 2)
mock_real_ip(app)("200.201.202.204") mock_real_ip(app)("200.201.202.204")
with patch('homeassistant.components.http.ban.async_load_ip_bans_config', with patch('homeassistant.components.http.ban.async_load_ip_bans_config',