jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2026-04-06 23:47:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add OPENING/CLOSING states to Z-Wave JS multilevel switch covers

Browse Source 
Co-authored-by: edenhaus <26537646+edenhaus@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-16 13:44:51 +00:00
parent a7d342fe9b
commit e547e84df7
2 changed files with 180 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
homeassistant/components/zwave_js/cover.py
View File

@@ -138,6 +138,30 @@ class CoverPositionMixin(ZWaveBaseEntity, CoverEntity):
"""Return range between fully opened and fully closed position."""
return self._fully_open_position - self._fully_closed_position
@property
def is_opening(self) -> bool | None:
"""Return if the cover is opening or not."""
if (
not self._current_position_value
or self._current_position_value.value is None
or not self._target_position_value
or self._target_position_value.value is None
):
return None
return bool(self._target_position_value.value > self._current_position_value.value)
@property
def is_closing(self) -> bool | None:
"""Return if the cover is closing or not."""
if (
not self._current_position_value
or self._current_position_value.value is None
or not self._target_position_value
or self._target_position_value.value is None
):
return None
return bool(self._target_position_value.value < self._current_position_value.value)
@property
def is_closed(self) -> bool | None:
"""Return true if cover is closed."""

156
tests/components/zwave_js/test_cover.py
View File

@@ -1202,3 +1202,159 @@ async def test_window_covering_open_close(
assert args["value"] is False
client.async_send_command.reset_mock()
async def test_multilevel_switch_cover_state(
hass: HomeAssistant, client, aeotec_nano_shutter, integration
) -> None:
"""Test multilevel switch cover states including OPENING and CLOSING."""
node = aeotec_nano_shutter
state = hass.states.get(AEOTEC_SHUTTER_COVER_ENTITY)
assert state
assert state.state == CoverState.CLOSED
assert state.attributes[ATTR_CURRENT_POSITION] == 0
# Simulate opening: Set targetValue to 99 while currentValue is still 0
event = Event(
type="value updated",
data={
"source": "node",
"event": "value updated",
"nodeId": 3,
"args": {
"commandClassName": "Multilevel Switch",
"commandClass": 38,
"endpoint": 0,
"property": "targetValue",
"newValue": 99,
"prevValue": 0,
"propertyName": "targetValue",
},
},
)
node.receive_event(event)
state = hass.states.get(AEOTEC_SHUTTER_COVER_ENTITY)
assert state.state == CoverState.OPENING
# Simulate cover moving: currentValue is now 50, targetValue is still 99
event = Event(
type="value updated",
data={
"source": "node",
"event": "value updated",
"nodeId": 3,
"args": {
"commandClassName": "Multilevel Switch",
"commandClass": 38,
"endpoint": 0,
"property": "currentValue",
"newValue": 50,
"prevValue": 0,
"propertyName": "currentValue",
},
},
)
node.receive_event(event)
state = hass.states.get(AEOTEC_SHUTTER_COVER_ENTITY)
assert state.state == CoverState.OPENING
assert state.attributes[ATTR_CURRENT_POSITION] == 51
# Simulate cover fully opened: currentValue reaches targetValue
event = Event(
type="value updated",
data={
"source": "node",
"event": "value updated",
"nodeId": 3,
"args": {
"commandClassName": "Multilevel Switch",
"commandClass": 38,
"endpoint": 0,
"property": "currentValue",
"newValue": 99,
"prevValue": 50,
"propertyName": "currentValue",
},
},
)
node.receive_event(event)
state = hass.states.get(AEOTEC_SHUTTER_COVER_ENTITY)
assert state.state == CoverState.OPEN
assert state.attributes[ATTR_CURRENT_POSITION] == 100
# Simulate closing: Set targetValue to 0 while currentValue is still 99
event = Event(
type="value updated",
data={
"source": "node",
"event": "value updated",
"nodeId": 3,
"args": {
"commandClassName": "Multilevel Switch",
"commandClass": 38,
"endpoint": 0,
"property": "targetValue",
"newValue": 0,
"prevValue": 99,
"propertyName": "targetValue",
},
},
)
node.receive_event(event)
state = hass.states.get(AEOTEC_SHUTTER_COVER_ENTITY)
assert state.state == CoverState.CLOSING
# Simulate cover moving: currentValue is now 50, targetValue is still 0
event = Event(
type="value updated",
data={
"source": "node",
"event": "value updated",
"nodeId": 3,
"args": {
"commandClassName": "Multilevel Switch",
"commandClass": 38,
"endpoint": 0,
"property": "currentValue",
"newValue": 50,
"prevValue": 99,
"propertyName": "currentValue",
},
},
)
node.receive_event(event)
state = hass.states.get(AEOTEC_SHUTTER_COVER_ENTITY)
assert state.state == CoverState.CLOSING
assert state.attributes[ATTR_CURRENT_POSITION] == 51
# Simulate cover fully closed: currentValue reaches targetValue
event = Event(
type="value updated",
data={
"source": "node",
"event": "value updated",
"nodeId": 3,
"args": {
"commandClassName": "Multilevel Switch",
"commandClass": 38,
"endpoint": 0,
"property": "currentValue",
"newValue": 0,
"prevValue": 50,
"propertyName": "currentValue",
},
},
)
node.receive_event(event)
state = hass.states.get(AEOTEC_SHUTTER_COVER_ENTITY)
assert state.state == CoverState.CLOSED
assert state.attributes[ATTR_CURRENT_POSITION] == 0