jeans/core
jeans/core
1
0
Fork 0
mirror of https://github.com/home-assistant/core.git synced 2025-07-10 06:47:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix feedback in ROVA (#114308)

Browse Source
This commit is contained in:
Joost Lekkerkerker 2024-03-27 18:01:07 +01:00 committed by GitHub
parent 6f1b4fad01
commit e626cd12aa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
homeassistant/components/rova/sensor.py
View File

@ -94,12 +94,12 @@ async def async_setup_platform(
async_create_issue(
hass,
DOMAIN,
f"deprecated_yaml_import_issue_${result['reason']}",
f"deprecated_yaml_import_issue_{result['reason']}",
breaks_in_ha_version="2024.10.0",
is_fixable=False,
issue_domain=DOMAIN,
severity=IssueSeverity.WARNING,
translation_key=f"deprecated_yaml_import_issue_${result['reason']}",
translation_key=f"deprecated_yaml_import_issue_{result['reason']}",
translation_placeholders=ISSUE_PLACEHOLDER,
)

2
homeassistant/components/rova/strings.json
View File

@ -23,7 +23,7 @@
"issues": {
"deprecated_yaml_import_issue_cannot_connect": {
"title": "The Rova YAML configuration import failed",
"description": "Configuring Rova using YAML is being removed but there was an connection error importing your YAML configuration.\n\nEnsure connection to Rova works and restart Home Assistant to try again or remove the Rova YAML configuration from your configuration.yaml file and continue to [set up the integration]({url}) manually."
"description": "Configuring Rova using YAML is being removed but there was a connection error importing your YAML configuration.\n\nEnsure connection to Rova works and restart Home Assistant to try again or remove the Rova YAML configuration from your configuration.yaml file and continue to [set up the integration]({url}) manually."
},
"deprecated_yaml_import_issue_invalid_rova_area": {
"title": "The Rova YAML configuration import failed",

4
tests/components/rova/test_config_flow.py
View File

@ -49,10 +49,10 @@ async def test_user(hass: HomeAssistant, mock_rova: MagicMock) -> None:
assert data[CONF_HOUSE_NUMBER_SUFFIX] == HOUSE_NUMBER_SUFFIX
async def test_abort_if_not_rova_area(
async def test_error_if_not_rova_area(
hass: HomeAssistant, mock_rova: MagicMock
) -> None:
"""Test we abort if rova does not collect at the given address."""
"""Test we raise errors if rova does not collect at the given address."""
result = await hass.config_entries.flow.async_init(
DOMAIN, context={"source": SOURCE_USER}
)