Merge branch 'dev' into edenhaus-ecovacs-quality-scale

homeassistant/components/ecovacs/config_flow.py

@@ -172,7 +172,13 @@ class EcovacsConfigFlow(ConfigFlow, domain=DOMAIN):
         errors = {}
 
         if user_input:
-            self._async_abort_entries_match({CONF_USERNAME: user_input[CONF_USERNAME]})
+            self._async_abort_entries_match(
+                {
+                    CONF_USERNAME: user_input[CONF_USERNAME],
+                    CONF_OVERRIDE_REST_URL: user_input.get(CONF_OVERRIDE_REST_URL),
+                    CONF_OVERRIDE_MQTT_URL: user_input.get(CONF_OVERRIDE_MQTT_URL),
+                }
+            )
 
             errors = await _validate_input(self.hass, user_input)
 
@@ -214,6 +220,9 @@ class EcovacsConfigFlow(ConfigFlow, domain=DOMAIN):
             data_schema=self.add_suggested_values_to_schema(
                 data_schema=vol.Schema(schema), suggested_values=user_input
             ),
+            description_placeholders={
+                "account_name": "Ecovacs",
+            },
             errors=errors,
             last_step=True,
         )

homeassistant/components/ecovacs/quality_scale.yaml

@@ -0,0 +1,95 @@
+rules:
+  # Bronze
+  config-flow: done
+  test-before-configure: done
+  unique-config-entry: done
+  config-flow-test-coverage: done
+  runtime-data: done
+  test-before-setup:
+    status: todo
+    comment: Legacy code will not raise on setup currently
+  appropriate-polling:
+    status: todo
+    comment: |
+      @mib1185 Please check legacy code.
+      deebot-client pulls only once at beginning and afterwards is pushed based
+  entity-unique-id: done
+  has-entity-name: done
+  entity-event-setup: done
+  dependency-transparency:
+    status: todo
+    comment: Currently unsure if all dependencies need to validated or only direct ones.
+  action-setup:
+    status: done
+    comment: "`raw_get_positions` is a entity service"
+  common-modules: done
+  docs-high-level-description: todo
+  docs-installation-instructions: todo
+  docs-removal-instructions: todo
+  docs-actions: todo
+  brands: done
+
+  # Silver
+  config-entry-unloading: done
+  log-when-unavailable: todo
+  entity-unavailable: done
+  action-exceptions: todo
+  reauthentication-flow: todo
+  parallel-updates:
+    status: todo
+    comment: |
+      @mib1185 Please check legacy code.
+      deebot-client uses internally semaphores to prevent to many parallel requests
+  test-coverage: todo
+  integration-owner: done
+  docs-installation-parameters: todo
+  docs-configuration-parameters: todo
+
+  # Gold
+  entity-translations:
+    status: todo
+    comment: |
+      @mib1185 Legacy entities are not translated
+  entity-device-class: done
+  devices: done
+  entity-category: done
+  entity-disabled-by-default: done
+  discovery:
+    status: exempt
+    comment: Not supported as we don't talk directly to the devices
+  stale-devices: todo
+  diagnostics: done
+  exception-translations: todo
+  icon-translations: done
+  reconfiguration-flow: todo
+  dynamic-devices:
+    status: todo
+    comment: New devices are discovered only on boot currently
+  discovery-update-info:
+    status: exempt
+    comment: Not supported as we don't talk directly to the devices
+  repair-issues: todo
+  docs-use-cases: todo
+  docs-supported-devices: todo
+  docs-supported-functions: todo
+  docs-data-update: todo
+  docs-known-limitations: todo
+  docs-troubleshooting: todo
+  docs-examples: todo
+
+  # Platinum
+  async-dependency:
+    status: todo
+    comment: |
+      @mib1185 Please check legacy code.
+      deebot-client is async
+  inject-websession:
+    status: todo
+    comment: |
+      @mib1185 Please check legacy code.
+      deebot-client uses the passed websession
+  strict-typing:
+    status: todo
+    comment: |
+      @mib1185 Please check legacy code.
+      deebot-client is typed

homeassistant/components/ecovacs/strings.json

@@ -22,8 +22,12 @@
           "verify_mqtt_certificate": "Verify MQTT SSL certificate"
         },
         "data_description": {
+          "country": "The country of your {account_name} account.",
           "override_rest_url": "Enter the REST URL of your self-hosted instance including the scheme (http/https).",
-          "override_mqtt_url": "Enter the MQTT URL of your self-hosted instance including the scheme (mqtt/mqtts)."
+          "override_mqtt_url": "Enter the MQTT URL of your self-hosted instance including the scheme (mqtt/mqtts).",
+          "password": "[%key:common::config_flow::data_description::password%]",
+          "username": "[%key:common::config_flow::data_description::username%]",
+          "verify_mqtt_certificate": "Should SSL certificates be verified? Uncheck this checkbox only if you are using a self-signed certificate."
         }
       },
       "user": {

homeassistant/strings.json

@@ -70,6 +70,10 @@
         "username": "Username",
         "verify_ssl": "Verify SSL certificate"
       },
+      "data_description": {
+        "username": "The username of your {account_name} account.",
+        "password": "The password of your {account_name} account."
+      },
       "description": {
         "confirm_setup": "Do you want to start setup?"
       },

script/hassfest/quality_scale.py

@@ -325,7 +325,6 @@ INTEGRATIONS_WITHOUT_QUALITY_SCALE_FILE = [
     "ecobee",
     "ecoforest",
     "econet",
-    "ecovacs",
     "ecowitt",
     "eddystone_temperature",
     "edimax",