mirror of
https://github.com/home-assistant/developers.home-assistant.git
synced 2025-07-16 22:06:29 +00:00
Add ADR to the PR review process (#1882)
* Update review-process.md * Update review-process.md * mod
This commit is contained in:
parent
e93461da02
commit
7d2aebb3e5
@ -31,6 +31,16 @@ or even just a "I tested this using ... and it works" is very much appreciated.
|
||||
Besides, looking at code of others is a great way to learn more about
|
||||
Home Assistant.
|
||||
|
||||
## Before creating your PR
|
||||
|
||||
**Comply with Architectural Decisions.**
|
||||
|
||||
All architectural decisions around the Home Assistant project are recorded in
|
||||
the [ADR folder](https://github.com/home-assistant/architecture/tree/master/adr).
|
||||
Ensure these rules and guidelines are followed before creating your PR
|
||||
to avoid later adjustments based on your PR not following these rules.
|
||||
If needed a new [discussion](https://github.com/home-assistant/architecture/discussions) can take place to make the necessary decision prior to submitting a PR for review.
|
||||
|
||||
## Creating the perfect PR
|
||||
|
||||
There is no such thing as a perfect PR, but there are some things you can
|
||||
|
Loading…
x
Reference in New Issue
Block a user