jeans/developers.home-assistant
jeans/developers.home-assistant
1
0
Fork 0
mirror of https://github.com/home-assistant/developers.home-assistant.git synced 2025-07-22 00:36:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add ADR to the PR review process (#1882)

Browse Source 
* Update review-process.md

* Update review-process.md

* mod
This commit is contained in:
G Johansson 2023-08-23 07:15:46 +02:00 committed by GitHub
parent e93461da02
commit 7d2aebb3e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/review-process.md
View File

@ -31,6 +31,16 @@ or even just a "I tested this using ... and it works" is very much appreciated.
Besides, looking at code of others is a great way to learn more about
Home Assistant.
## Before creating your PR
**Comply with Architectural Decisions.**
All architectural decisions around the Home Assistant project are recorded in
the [ADR folder](https://github.com/home-assistant/architecture/tree/master/adr).
Ensure these rules and guidelines are followed before creating your PR
to avoid later adjustments based on your PR not following these rules.
If needed a new [discussion](https://github.com/home-assistant/architecture/discussions) can take place to make the necessary decision prior to submitting a PR for review.
## Creating the perfect PR
There is no such thing as a perfect PR, but there are some things you can