jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-04-25 15:57:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(MAINTAINERS.md): steps to upgrade electron (#501)

Browse Source 
This PR documents the process to upgrade the Electron version correctly,
in order to prevent any potential compatibility issue when building
native dependencies.

Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
This commit is contained in:
Juan Cruz Viotti 2016-06-22 10:40:45 -04:00 committed by GitHub
parent 447c67c58f
commit 24f442a8fc
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
docs/MAINTAINERS.md
View File

@ -40,3 +40,14 @@ git tag -a v1.0.0 -m "v1.0.0"
git push
git push --tags
```
Upgrading Electron
------------------
- Upgrade the `electron-prebuilt` dependency version in `package.json` to an *exact version* (no `~`, `^`, etc).
- Find the exact NodeJS version included in the desired Electron version and update `engines.node` in `package.json` appropriately. This can be usually found in the [Electron releases page](https://github.com/electron/electron/releases).
- Update the `NODE_VERSION` environment variable in `.travis.yml`.
- Update the `nodejs_version` and `npm_config_target` environment variables in `appveyor.yml`.