jeans/etcher
jeans/etcher
1
0
Fork 0
mirror of https://github.com/balena-io/etcher.git synced 2025-07-22 18:56:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(GUI): don't clear selection state when re-selecting an image (#753)

Browse Source 
Currently, if the "CHANGE" label at the bottom of the image selection
step, once an image has been selected, is clicked, the selection state
is cleared.

Since https://github.com/resin-io/etcher/pull/602, we allow the drive
state to change independently of the image selection state, so the above
behaviour doesn't make sense anymore.

Fixes: https://github.com/resin-io/etcher/issues/730
Change-Type: patch
Changelog-Entry: Don't clear selection state when re-selecting an image.
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
This commit is contained in:
Juan Cruz Viotti 2016-10-07 15:32:16 -03:00 committed by GitHub
parent 4e5b000440
commit 60e3cbd22d
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/gui/pages/main/controllers/image-selection.js
View File

@ -97,13 +97,6 @@ module.exports = function(SupportedFormatsModel, SelectionStateModel, AnalyticsS
* ImageSelectionController.reselectImage(); * ImageSelectionController.reselectImage();
*/ */
this.reselectImage = () => { this.reselectImage = () => {
// Reselecting an image automatically
// de-selects the current drive, if any.
// This is made so the user effectively
// "returns" to the first step.
SelectionStateModel.clear();
this.openImageSelector(); this.openImageSelector();
AnalyticsService.logEvent('Reselect image'); AnalyticsService.logEvent('Reselect image');
}; };