Juan Cruz Viotti f16e176b0f minifix(GUI): keep settings checkboxes unchecked until user confirms (#821)
There are some settings, such as "unsafe mode", that prompt the user for
confirmation before actually confirming the setting. In these cases,
when the user attempts to check the checkbox, the checkbox remains
checked unless the user rejects the confirmation dialog, in which case
the checkbox value is reverted.

In order to provide a better UX, we now keep the checkbox unchecked
until the user confirms.

See: https://github.com/resin-io/etcher/issues/729
Signed-off-by: Juan Cruz Viotti <jviotti@openmailbox.org>
2016-11-02 18:25:29 -04:00

85 lines
1.9 KiB
JavaScript

/*
* Copyright 2016 Resin.io
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
'use strict';
const os = require('os');
module.exports = function(WarningModalService, SettingsModel) {
/**
* @summary Client platform
* @type String
* @constant
* @public
*/
this.platform = os.platform();
/**
* @summary Refresh current settings
* @function
* @public
*/
this.refreshSettings = () => {
this.currentData = SettingsModel.getAll();
};
/**
* @summary Current settings value
* @type Object
* @public
*/
this.currentData = {};
this.refreshSettings();
/**
* @summary Settings model
* @type Object
* @public
*/
this.model = SettingsModel;
/**
* @summary Enable a dangerous setting
* @function
* @public
*
* @param {String} name - setting name
* @param {String} message - danger message
* @returns {Undefined}
*
* @example
* SettingsController.enableDangerousSetting('unsafeMode', 'Don\'t do this!');
*/
this.enableDangerousSetting = (name, message) => {
if (!this.currentData[name]) {
this.model.set(name, false);
return this.refreshSettings();
}
// Keep the checkbox unchecked until the user confirms
this.currentData[name] = false;
WarningModalService.display(message).then((userAccepted) => {
if (userAccepted) {
this.model.set(name, true);
this.refreshSettings();
}
});
};
};