home-assistant.io/source/developers/development_submitting.markdown
Peter Epley 87cd795a85 Update development_submitting.markdown (#3782)
* Update development_submitting.markdown

Added notes helpful for comparing and requesting a pull (ex. to avoid proposing merge of dev and master accidentally).

* Update format
2017-10-26 09:58:56 +02:00

2.3 KiB

layout, title, description, date, sidebar, comments, sharing, footer
layout title description date sidebar comments sharing footer
page Submit your work Submit your work as Pull Request for Home Assistant. 2016-07-01 20:00 true false true true

Submit your improvements, fixes, and new features to Home Assistant one at a time, using GitHub Pull Requests. Here are the steps:

  1. From your fork's dev branch, create a new branch to hold your changes:

    git checkout -b some-feature

  2. Make your changes, create a new platform, develop a new component, or fix issues.

  3. Test your changes and check for style violations.

  4. If everything looks good according to these musts, commit your changes:

    git add .

    git commit -m "Added some-feature"

    • Write a meaningful commit message and not only Update or Fix.
    • Use a capital letter to start with your commit message.
    • Don't prefix your commit message with [bla.bla] or platform:.
    • Consider adding tests to ensure that your code works.
  5. Push your committed changes back to your fork on GitHub:

    git push origin HEAD

  6. Follow these steps to create your pull request.

    • On GitHub, navigate to the main page of the Home Assistant repository.
    • In the "Branch" menu, choose the branch that contains your commits (from your fork).
    • To the right of the Branch menu, click New pull request.
    • Use the base branch dropdown menu to select the branch you'd like to merge your changes into, then use the compare branch drop-down menu to choose the topic branch you made your changes in. Make sure the Home Assistant branch matches with your forked branch (dev) else you will propose ALL committs between branches.
    • Type a title and complete the provided description for your pull request.
    • Click Create pull request.
  7. Check for comments and suggestions on your pull request and keep an eye on the CI output.