jeans/ollama
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

backend: Don't return an error on Close

Browse Source 
It is not common to return errors with close/free operations - most
people won't check it and even if they did there's probably not much
that can do. It's better to not give implementations false expectations.
This commit is contained in:
Jesse Gross 2025-02-04 19:49:34 -08:00 committed by Jesse Gross
parent 58245413f4
commit 7e13f568dc
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ml/backend.go
View File

@ -50,7 +50,7 @@ type Context interface {
Forward(Tensor) Forward(Tensor)
Compute(Tensor) Tensor Compute(Tensor) Tensor
Close() error Close()
} }
type Tensor interface { type Tensor interface {

3
ml/backend/ggml/ggml.go
View File

@ -306,10 +306,9 @@ func (c Context) FromIntSlice(s []int32, shape ...int) (ml.Tensor, error) {
return fromSlice(c, s, shape, C.GGML_TYPE_I32) return fromSlice(c, s, shape, C.GGML_TYPE_I32)
} }
func (c *Context) Close() error { func (c *Context) Close() {
C.ggml_backend_sched_free(c.sched) C.ggml_backend_sched_free(c.sched)
C.ggml_free(c.ctx) C.ggml_free(c.ctx)
return nil
} }
type Tensor struct { type Tensor struct {